OV-43: Add PWA #47
Merged
OV-43: Add PWA #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilsonBravo
requested review from
nikita-remeslov,
anton-otroshchenko and
sofiia-trokhymchuk
as code owners
Closed
anton-otroshchenko
approved these changes
Aug 22, 2024
o-nedashkivska
previously approved these changes
Aug 22, 2024
JKaypa
previously approved these changes
Aug 22, 2024
| "vite": "5.4.0" | ||
| "vite": "5.4.0", | ||
| "vite-plugin-pwa": "0.20.1", | ||
| "workbox-core": "7.1.0" |
There was a problem hiding this comment.
why we need this package?
There was a problem hiding this comment.
From what I understand, the Vite PWA plugin will use the Workbox Core library to interact with and build the service worker.
https://vite-pwa-org.netlify.app/workbox/
nikita-remeslov
previously approved these changes
Aug 27, 2024
anton-otroshchenko
previously approved these changes
Aug 27, 2024
WilsonBravo
dismissed stale reviews from anton-otroshchenko, nikita-remeslov, JKaypa, and o-nedashkivska
via
3f64270
|
Please fix conflicts |
o-nedashkivska
approved these changes
Aug 29, 2024
anton-otroshchenko
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I configured the Vite PWA plugin with next settings:
registerType: 'autoUpdate': Ensures the service worker updates automatically in the background.injectRegister: false: Disables automatic script injection, allowing for manual control if needed.pwaAssets: Enabled asset generation to ensure all necessary icons and resources are created.manifest: Defines the app's name, theme color, and description to enhance its appearance and identity on user devices.workbox: Configured caching with specific patterns, cleanup of outdated caches, and immediate control of pages.devOptions: Enabled the service worker in development, set up fallback handling, suppressed non-critical warnings, and used module type for the service worker.